On Wed, Aug 02, 2017 at 02:33:00PM +0200, Halil Pasic wrote: > > > On 08/02/2017 01:01 AM, Eduardo Habkost wrote: > > TYPE_VIRTIO_DEVICE devices are already not usable with -device > > and device_add, but they are reported as user-creatable on > > "-device help" and through monitor interfaces. > > I've tried -device virtio-rng on s390x and from what I see, it > seems we 'auto-magically' create the 'controlling' virtio-rng-ccw > device. So I have to ask what do you mean by 'already not usable'?
virtio-rng is just an alias for virtio-rng-<transport>, and it's not a TYPE_VIRTIO_DEVICE device. virtio-rng-device is the TYPE_VIRTIO_DEVICE subclass, and you shouldn't be able to use "-device virtio-rng-device". Except that it works with "qemu-system-arm -machine virt", as I noted on another message, and this patch breaks it. -- Eduardo
