On Thu, Nov 18, 2010 at 03:46:32PM +0100, Hannes Reinecke wrote: > > The SCSI emulation is supposed to return status codes as defined > by SAM, not the linux ones which are shifted by one.
When just looking at the patch the description is rather confusing as all places touched were already returning the correct value by doing the opencoded shift. Only a little grepping reveals that there are lots of other incorrect uses, too. You might consider mentioning this in the patch description.