On Thu, Nov 18, 2010 at 03:47:28PM +0100, Hannes Reinecke wrote: > > Rather than to access a SCSIRequest via an abstract 'tag' we can > as well use it directly and save us the lookup.
The get_put/buf methods are a bit misnamed. get/put generally implies refcounting while they are simple alloc/free routines. I'd suggest renaming them to alloc_buf/free_buf. Otherwise the patch looks very good to me.