Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL 0/9] Tracing patches
Message-id: 20170801131618.27332-1-stefa...@redhat.com
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ea1ac22b6f monitor: Reduce handle_qmp_command() tracing overhead
310790af52 trace-events: fix code style: print 0x before hex numbers
f401de6d78 checkpatch: check trace-events code style
5338cd3bca trace-events: fix code style: %# -> 0x%
78b7ef9c66 coding_style: add point about 0x in trace-events
e13fc57ae9 trace: add trace_event_get_state_backends()
abc647bba6 trace: add TRACE_<event>_BACKEND_DSTATE()
1dd27d433d trace: ensure unique function / variable names per .stp file
dc8a17bea0 trace: ensure .stp files are rebuilt if trace tool source changes
=== OUTPUT BEGIN ===
Checking PATCH 1/9: trace: ensure .stp files are rebuilt if trace tool source
changes...
Checking PATCH 2/9: trace: ensure unique function / variable names per .stp
file...
Checking PATCH 3/9: trace: add TRACE_<event>_BACKEND_DSTATE()...
Checking PATCH 4/9: trace: add trace_event_get_state_backends()...
Checking PATCH 5/9: coding_style: add point about 0x in trace-events...
Checking PATCH 6/9: trace-events: fix code style: %# -> 0x%...
Checking PATCH 7/9: checkpatch: check trace-events code style...
WARNING: line over 80 characters
#28: FILE: scripts/checkpatch.pl:1343:
+ ERROR("Don't use '#' flag of printf format
('%#') in " .
ERROR: line over 90 characters
#29: FILE: scripts/checkpatch.pl:1344:
+ "trace-events, use '0x' prefix instead\n"
. $herecurr);
ERROR: line over 90 characters
#32: FILE: scripts/checkpatch.pl:1347:
+ qr/%[-+
*.0-9]*([hljztL]|ll|hh)?(x|X|"\s*PRI[xX][^"]*"?)/;
ERROR: line over 90 characters
#34: FILE: scripts/checkpatch.pl:1349:
+ # don't consider groups splitted by [.:/ ],
like 2A.20:12ab
WARNING: line over 80 characters
#35: FILE: scripts/checkpatch.pl:1350:
+ my $tmpline = $rawline =~ s/($hex[.:\/
])+$hex//gr;
WARNING: line over 80 characters
#38: FILE: scripts/checkpatch.pl:1353:
+ ERROR("Hex numbers must be prefixed
with '0x'\n" .
total: 3 errors, 3 warnings, 25 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 8/9: trace-events: fix code style: print 0x before hex numbers...
Checking PATCH 9/9: monitor: Reduce handle_qmp_command() tracing overhead...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
