On Wed, Jul 26, 2017 at 06:46:30AM +0200, Lukáš Doktor wrote: > Dne 25.7.2017 v 21:34 Eduardo Habkost napsal(a): > > On Tue, Jul 25, 2017 at 05:09:50PM +0200, Lukáš Doktor wrote: > >> The "id" is a builtin method to get object's identity and should not be > >> overridden. This might bring some issues in case someone was directly > >> calling "cmd(..., id=id)" but I haven't found such usage on brief search > >> for "cmd\(.*id=". > >> > >> Signed-off-by: Lukáš Doktor <ldok...@redhat.com> > > > > I don't see the benefit of the patch, as the function is very > > short and unlikely to ever use the id() builtin. But I am not > > against it if it will silence code analyzer warnings. > > > For me the biggest benefit is it decreases the probability of > someone copying the same "idea" to other pieces of code, > because, you know, developers are using copy&paste way too > often. > > Anyway pylint does complain about this issue. I can either > ignore it, skip it with an informative comment `# use id for > backward compatibility pylint: disable=W0622` or use this patch > to fix it properly. I'm inclined towards fixing it (until it > poisons other parts of the code), you are in favor of ignoring > it, so let's see whether someone else has another opinion, > otherwise I'll remove it in v3.
If pylint complains about it, it won't hurt to make it happy. Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> -- Eduardo
