On Fri, Jul 21, 2017 at 03:53:19PM +0200, Markus Armbruster wrote:
> From: Eric Blake <ebl...@redhat.com>
>
> We have two flavors of vararg usage in qtest; make it clear that
> qmp() has different semantics than hmp(), and let the compiler
> enforce that hmp() is used correctly. However, qmp() (and friends)
> only accept a subset of printf flags look-alikes (namely, those
> that our JSON parser understands), and what is worse, qmp("true")
> (the JSON keyword 'true') is different from qmp("%s", "true")
> (the JSON string '"true"'), so marking those as printf-like would
> produce more harm from bogus warnings than it helps (we may have
> made a mistake in previously marking qobject_from_jsonf(), but
> this patch is not addressing that).
>
> Signed-off-by: Eric Blake <ebl...@redhat.com>
> Message-Id: <20170720214008.28494-5-ebl...@redhat.com>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> ---
> tests/libqtest.h | 22 ++++++++++++++--------
> 1 file changed, 14 insertions(+), 8 deletions(-)Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature
