Le 24/07/2017 à 20:27, Philippe Mathieu-Daudé a écrit : > linux-user/syscall.c:1627:35: warning: 1st function call argument is an > uninitialized value > target_saddr->sa_family = tswap16(addr->sa_family); > ^~~~~~~~~~~~~~~~~~~~~~~~ > linux-user/syscall.c:1629:25: warning: The left operand of '==' is a garbage > value > if (addr->sa_family == AF_NETLINK && len >= sizeof(struct sockaddr_nl)) { > ~~~~~~~~~~~~~~~ ^ > > Reported-by: Clang Static Analyzer > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > linux-user/syscall.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 26450d235f..963b9c8f4b 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -1618,6 +1618,7 @@ static inline abi_long > host_to_target_sockaddr(abi_ulong target_addr, > if (len == 0) { > return 0; > } > + assert(addr); > > target_saddr = lock_user(VERIFY_WRITE, target_addr, len, 0); > if (!target_saddr) >
Reviewed-by: Laurent Vivier <laur...@vivier.eu>