On Fri, Jul 21, 2017 at 01:35:46PM +0200, Andrew Jones wrote: > On Fri, Jul 21, 2017 at 01:16:07PM +0200, Christoffer Dall wrote: > > On Wed, Jul 19, 2017 at 09:39:54AM -0400, Andrew Jones wrote: > > > Mimicking gicv3-maintenance-interrupt, add the PMU's interrupt to > > > CPU state. > > > > > > Signed-off-by: Andrew Jones <drjo...@redhat.com> > > > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> > > > --- > > > hw/arm/virt.c | 3 +++ > > > target/arm/cpu.c | 2 ++ > > > target/arm/cpu.h | 2 ++ > > > 3 files changed, 7 insertions(+) > > > > > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > > > index 31739d75a3e0..ea26f0c473c2 100644 > > > --- a/hw/arm/virt.c > > > +++ b/hw/arm/virt.c > > > @@ -610,6 +610,9 @@ static void create_gic(VirtMachineState *vms, > > > qemu_irq *pic) > > > qdev_connect_gpio_out_named(cpudev, > > > "gicv3-maintenance-interrupt", 0, > > > qdev_get_gpio_in(gicdev, ppibase > > > + > > > ARCH_GICV3_MAINT_IRQ)); > > > + qdev_connect_gpio_out_named(cpudev, "pmu-interrupt", 0, > > > + qdev_get_gpio_in(gicdev, ppibase > > > + + VIRTUAL_PMU_IRQ)); > > > > I know Peter reviewed this, but isn't it a bit strange to create the > > pmu-interrupt when creating the gic (as this isn't an output from the > > GIC like the maintenance interrupt is) ? > > > > Above the gic maintenance interrupt connection the timer irqs are also > connected. So, while the function name implies we only create the gic, > its function appears to be both its creation and the wiring up of CPU > inputs and outputs. >
ok, I didn't see that. Otherwise this patch looks good to me. -Christoffer
