----- On Jul 20, 2017, at 6:16 PM, stefanha stefa...@redhat.com wrote: > On Tue, Jul 18, 2017 at 12:45:36AM +0530, Ishani Chugh wrote: > > This looks good. I think it makes sense to include this patch with the > patch series that adds the qemu-backup command. That way the command > and its man page will be merged together.
Thanks. I will include the patch for qemu-backup in same patch series. >> +@item qemu-backup guest add --guest guestname --qmp socketpath [--tcp] > > For consistency I suggest following QEMU chardev syntax for the socket > path. This also allows you to drop --tcp. > > UNIX domain sockets look like this: > > unix:/path/to/socket > > TCP addresses look like this: > > tcp:127.0.0.1:1234 Okay. Will fix it in next revision.Thanks.
