On 07/18/2017 12:08 PM, anton.iva...@cambridgegreys.com wrote: > From: Anton Ivanov <anton.iva...@cambridgegreys.com> > > This adds raw socket support to the unified socket driver. > > Signed-off-by: Anton Ivanov <anton.iva...@cambridgegreys.com> > ---
Interface review only.
> +++ b/qapi-schema.json
> @@ -3883,6 +3883,21 @@
> '*txkey': 'uint32',
> '*rxkey': 'uint32' } }
> ##
> +# @NetdevRawOptions:
> +#
> +# Connect the VLAN to an network interface using raw sockets
> +#
> +# @ifname: network interface name
> +#
> +
Missing #
> +# Since 2.9
Same comments as on 2/3 - you've got the wrong version.
> +##
> +{ 'struct': 'NetdevRawOptions',
> + 'data': {
> + 'ifname': 'str'
> +} }
> +
> +##
> # @NetdevVdeOptions:
> #
> # Connect the VLAN to a vde switch running on the host.
> @@ -4000,7 +4015,7 @@
> ##
> { 'enum': 'NetClientDriver',
> 'data': [ 'none', 'nic', 'user', 'tap', 'l2tpv3', 'socket', 'vde', 'dump',
> - 'bridge', 'hubport', 'netmap', 'vhost-user', 'gre' ] }
> + 'bridge', 'hubport', 'netmap', 'vhost-user', 'gre', 'raw' ] }
Missing comment on the 2.11 addition
> @@ -4062,7 +4078,7 @@
> ##
> { 'enum': 'NetLegacyOptionsType',
> 'data': ['none', 'nic', 'user', 'tap', 'l2tpv3', 'socket', 'vde',
> - 'dump', 'bridge', 'netmap', 'vhost-user', 'gre'] }
> + 'dump', 'bridge', 'netmap', 'vhost-user', 'gre', 'raw'] }
Again, this should NOT be added to NetLegacy.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
