On 07/18/2017 01:09 AM, Philippe Mathieu-Daudé wrote: > Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > net/eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/eth.c b/net/eth.c > index 5b9ba26a56..187a6812f6 100644 > --- a/net/eth.c > +++ b/net/eth.c > @@ -332,7 +332,7 @@ eth_setup_ip4_fragmentation(const void *l2hdr, size_t > l2hdr_len, > uint16_t frag_off_units = frag_offset / IP_FRAG_UNIT_SIZE; > uint16_t new_ip_off; > > - assert(frag_offset % IP_FRAG_UNIT_SIZE == 0); > + assert(QEMU_IS_ALIGNED(frag_offset, IP_FRAG_UNIT_SIZE)); > assert((frag_off_units & ~IP_OFFMASK) == 0);
This line is also a candidate for using the macro, albeit in the form QEMU_IS_ALIGNED(frag_off_units, IP_OFFMASK + 1), which might not make as much sense (but it DOES re-visit my question of whether the coccinelle script should be taught more patterns) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
