Ladi Prosek <lpro...@redhat.com> writes:
> Two more error functions that should not contain newlines.
>
> Suggested-by: Greg Kurz <gr...@kaod.org>
> Signed-off-by: Ladi Prosek <lpro...@redhat.com>
> ---
> scripts/checkpatch.pl | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 4e91122..2cd2713 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2540,7 +2540,9 @@ sub process {
> info_vreport|
> error_report|
> warn_report|
> - info_report}x;
> + info_report|
> + virtio_error|
> + virtqueue_error}x;
>
> if ($rawline =~ /\b(?:$qemu_error_funcs)\s*\(.*\".*\\n/) {
> ERROR("Error messages should not contain newlines\n" .
> $herecurr);
What makes the two functions appropriate for this list is this pattern:
va_start(ap, fmt);
msg = g_strdup_vprintf(fmt, ap);
va_end(ap);
error_report("... %s", ..., msg);
There's a related pattern using error_vreport().
Do we have more instances of these patterns?
Regardless:
Reviewed-by: Markus Armbruster <arm...@redhat.com>
