On 07/18/2017 08:41 AM, Markus Armbruster wrote: > Make visit_type_null() take an @obj argument like its buddies. This > helps keeing the next commit simple.
s/keeing/keep/
>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> ---
> +++ b/qapi/qobject-output-visitor.c
> @@ -187,7 +187,8 @@ static void qobject_output_type_any(Visitor *v, const
> char *name,
> qobject_output_add_obj(qov, name, *obj);
> }
>
> -static void qobject_output_type_null(Visitor *v, const char *name, Error
> **errp)
> +static void qobject_output_type_null(Visitor *v, const char *name,
> + QNull **obj, Error **errp)
> {
> QObjectOutputVisitor *qov = to_qov(v);
> qobject_output_add(qov, name, qnull());
would it be any better to call qobject_output_add(qov, name,
QINCREF(*obj)) here, to ensure we are indeed passing in an appropriate
QNull reference? But your patch is at least self-consistent in stating
we ignore obj in output visitors.
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
