> + /* Try to enable AIS facility */ > + kvm_vm_enable_cap(s, KVM_CAP_S390_AIS, 0); > + > qemu_mutex_init(&qemu_sigp_mutex); > > return 0; > @@ -2635,6 +2638,10 @@ void kvm_s390_get_host_cpu_model(S390CPUModel *model, > Error **errp) > set_bit(S390_FEAT_CMM, model->features); > } > > + /* set zpci and aen facilities */
This comment is not helpful. This should rather say something like "we emulate a zPCI bus in QEMU, therefore we don't depend on the host capabilities" > + set_bit(S390_FEAT_ZPCI, model->features); > + set_bit(S390_FEAT_ADAPTER_EVENT_NOTIFICATION, model->features); > + > if (s390_known_cpu_type(cpu_type)) { > /* we want the exact model, even if some features are missing */ > model->def = s390_find_cpu_def(cpu_type, ibc_gen(unblocked_ibc), > -- Thanks, David