On 07/17/2017 08:21 AM, Laurent Vivier wrote: > Only emit "XXX accelerator not found", if there are not > further accelerators listed. eg > > accel=kvm:tcg > > doesn't print a "KVM accelerator not found" warning > when it falls back to tcg, but a > > accel=kvm > > prints a warning, since no fallback is given. > > Suggested-by: Daniel P. Berrange <berra...@redhat.com> > Suggested-by: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Laurent Vivier <lviv...@redhat.com> > --- > accel/accel.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-)
> @@ -110,7 +110,8 @@ void configure_accelerator(MachineState *ms) > > if (!accel_initialised) { > if (!init_failed) { > - fprintf(stderr, "No accelerator found!\n"); > + fprintf(stderr, "-machine accel=%s: No accelerator found!\n", It may be worth dropping the '!', as we tend not to shout at the user; but whether or not you tweak that, Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature