----- Original Message ----- > From: "Philippe Mathieu-Daudé" <f4...@amsat.org> > To: "Paolo Bonzini" <pbonz...@redhat.com>, "Peter Maydell" > <peter.mayd...@linaro.org> > Cc: "Anthony PERARD" <anthony.per...@citrix.com>, "Stefano Stabellini" > <sstabell...@kernel.org>, "Alex Bennée" > <alex.ben...@linaro.org>, "QEMU Developers" <qemu-devel@nongnu.org> > Sent: Friday, July 14, 2017 5:26:36 PM > Subject: Re: [Qemu-devel] [PULL 22/42] configure: factor out list of > supported Xen/KVM/HAX targets > > what about this RFC series? > http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg02513.html
Too late for 2.10, but the way to go is to define a new "xenpv" target. In fact, --disable-tcg was the prerequisite for that if I remember correctly my old discussions with Citrix folks (could it have been Wei Liu?) Paolo > On 07/10/2017 01:28 PM, Paolo Bonzini wrote: > > On 10/07/2017 18:24, Peter Maydell wrote: > >> On 10 July 2017 at 17:14, Paolo Bonzini <pbonz...@redhat.com> wrote: > >>> On 10/07/2017 17:49, Peter Maydell wrote: > >>>> On 5 July 2017 at 08:14, Paolo Bonzini <pbonz...@redhat.com> wrote: > >>>>> This will be useful when the functions are called, early in the > >>>>> configure > >>>>> process, to filter out targets that do not support hardware > >>>>> acceleration. > >>>>> > >>>>> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > >>>> > >>>>> +supported_xen_target() { > >>>>> + test "$xen" = "yes" || return 1 > >>>>> + glob "$1" "*-softmmu" || return 1 > >>>>> + case "${1%-softmmu}:$cpu" in > >>>>> + arm:arm | aarch64:aarch64 | \ > >>>>> + i386:i386 | i386:x86_64 | x86_64:i386 | x86_64:x86_64) > >>>>> + return 0 > >>>>> + ;; > >>>> > >>>> This says that arm-on-arm and aarch64-on-aarch64 are supported > >>>> Xen targets... > >>> > >>> Hmm, this comes from my old patches. IIRC the reason for the change, > >>> when it wasn't a change (many conflicts ago) was that Xen folks were > >>> using --disable-tcg because their device model for Xen PV on ARM was > >>> actually an x86_64 QEMU. > >>> > >>> Stefano and Anthony, is this still true? If so, would it make sense to > >>> add the Xen PV machine type to qemu-system-arm---that is, is it > >>> something you can whip up easily, or should I just remove that line? > >> > >> I think you should just fix configure for the moment, because > >> this patch wasn't supposed to change anything about what we > >> build (AIUI). We can think about changing the Xen PV on ARM > >> build setup as a separate thing if we want to, I suspect it > >> is more invasive than a couple of lines changing in configure. > > > > Yes, definitely more invasive. > > > > I'll prepare a fix. > > > > Paolo > > >