On Fri, Jul 14, 2017 at 02:20:33AM -0400, Paolo Bonzini wrote: > > > NACK. > > > > It's not that simple. If you do it like this, you then suddenly get > > these ugly '"kvm" accelerator not found' messages during "make check" > > which we really should avoid. > > You're right, I thought these were shut up before with Laurent's patch. > I think we should print a single message at the end, like > > qemu: -machine accel=kvm:xen: No accelerator found > > Paolo
That's exactly Laurent's patch, isn't it? > > Laurent suggested some better ideas a couple of months ago, but I think > > the common sense was rather "unit tests should always use TCG" at that > > point in time: > > > > https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg00400.html > > > > Well, now that we've got the "--disable-tcg" configure option, we should > > maybe start to reconsider that ;-) > > > > So I'm fine with the patch if you also include Laurent's patch to shut > > up the error message: > > > > https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg00395.html > > > > Thomas > >
