we now pass the parameters to the zlib compressor if the
extension is present and use the old default values if
the extension is absent.
Signed-off-by: Peter Lieven <p...@kamp.de>
---
block/qcow2-cluster.c | 58 ++++++++++++++++++++++++++++++---------------------
block/qcow2.c | 57 +++++++++++++++++++++++++++-----------------------
2 files changed, 65 insertions(+), 50 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index f06c08f..6c14d59 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -1479,30 +1479,39 @@ again:
}
static int decompress_buffer(uint8_t *out_buf, int out_buf_size,
- const uint8_t *buf, int buf_size)
+ const uint8_t *buf, int buf_size,
+ int compress_format)
{
- z_stream strm1, *strm = &strm1;
- int ret, out_len;
-
- memset(strm, 0, sizeof(*strm));
-
- strm->next_in = (uint8_t *)buf;
- strm->avail_in = buf_size;
- strm->next_out = out_buf;
- strm->avail_out = out_buf_size;
-
- ret = inflateInit2(strm, -12);
- if (ret != Z_OK)
- return -1;
- ret = inflate(strm, Z_FINISH);
- out_len = strm->next_out - out_buf;
- if ((ret != Z_STREAM_END && ret != Z_BUF_ERROR) ||
- out_len != out_buf_size) {
- inflateEnd(strm);
- return -1;
- }
- inflateEnd(strm);
- return 0;
+ int ret = 0, out_len;
+
+ switch (compress_format) {
+ case QCOW2_COMPRESS_FORMAT_ZLIB:
+ case -1: {
+ z_stream z_strm = {};
+
+ z_strm.next_in = (uint8_t *)buf;
+ z_strm.avail_in = buf_size;
+ z_strm.next_out = out_buf;
+ z_strm.avail_out = out_buf_size;
+
+ ret = inflateInit2(&z_strm, -15);
+ if (ret != Z_OK) {
+ return -1;
+ }
+ ret = inflate(&z_strm, Z_FINISH);
+ out_len = z_strm.next_out - out_buf;
+ ret = -(ret != Z_STREAM_END);
+ inflateEnd(&z_strm);
+ break;
+ }
+ default:
+ abort(); /* should never reach this point */
+ }
+
+ if (out_len != out_buf_size) {
+ ret = -1;
+ }
+ return ret;
}
int qcow2_decompress_cluster(BlockDriverState *bs, uint64_t cluster_offset)
@@ -1523,7 +1532,8 @@ int qcow2_decompress_cluster(BlockDriverState *bs,
uint64_t cluster_offset)
return ret;
}
if (decompress_buffer(s->cluster_cache, s->cluster_size,
- s->cluster_data + sector_offset, csize) < 0) {
+ s->cluster_data + sector_offset, csize,
+ s->compress_format) < 0) {
return -EIO;
}
s->cluster_cache_offset = coffset;
diff --git a/block/qcow2.c b/block/qcow2.c
index ecb4bd6..68b8d3a 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -3391,9 +3391,10 @@ qcow2_co_pwritev_compressed(BlockDriverState *bs,
uint64_t offset,
BDRVQcow2State *s = bs->opaque;
QEMUIOVector hd_qiov;
struct iovec iov;
- z_stream strm;
- int ret, out_len;
- uint8_t *buf, *out_buf, *local_buf = NULL;
+ z_stream z_strm = {};
+ int z_windowBits = -15, z_level = Z_DEFAULT_COMPRESSION;
+ int ret, out_len = 0;
+ uint8_t *buf, *out_buf = NULL, *local_buf = NULL;
uint64_t cluster_offset;
if (bytes == 0) {
@@ -3418,34 +3419,38 @@ qcow2_co_pwritev_compressed(BlockDriverState *bs,
uint64_t offset,
buf = qiov->iov[0].iov_base;
}
- out_buf = g_malloc(s->cluster_size);
+ switch (s->compress_format) {
+ case -1:
+ z_windowBits = -12;
+ case QCOW2_COMPRESS_FORMAT_ZLIB:
+ out_buf = g_malloc(s->cluster_size);
+ if (s->compress_level > 0) {
+ z_level = s->compress_level;
+ }
- /* best compression, small window, no zlib header */
- memset(&strm, 0, sizeof(strm));
- ret = deflateInit2(&strm, Z_DEFAULT_COMPRESSION,
- Z_DEFLATED, -12,
- 9, Z_DEFAULT_STRATEGY);
- if (ret != 0) {
- ret = -EINVAL;
- goto fail;
- }
+ ret = deflateInit2(&z_strm, z_level, Z_DEFLATED, z_windowBits, 9,
+ Z_DEFAULT_STRATEGY);
+ if (ret != Z_OK) {
+ ret = -EINVAL;
+ goto fail;
+ }
- strm.avail_in = s->cluster_size;
- strm.next_in = (uint8_t *)buf;
- strm.avail_out = s->cluster_size;
- strm.next_out = out_buf;
+ z_strm.avail_in = s->cluster_size;
+ z_strm.next_in = (uint8_t *)buf;
+ z_strm.avail_out = s->cluster_size;
+ z_strm.next_out = out_buf;
- ret = deflate(&strm, Z_FINISH);
- if (ret != Z_STREAM_END && ret != Z_OK) {
- deflateEnd(&strm);
- ret = -EINVAL;
- goto fail;
- }
- out_len = strm.next_out - out_buf;
+ ret = deflate(&z_strm, Z_FINISH);
+ out_len = z_strm.next_out - out_buf;
+ deflateEnd(&z_strm);
- deflateEnd(&strm);
+ ret = ret != Z_STREAM_END;
+ break;
+ default:
+ abort(); /* should never reach this point */
+ }
- if (ret != Z_STREAM_END || out_len >= s->cluster_size) {
+ if (ret || out_len >= s->cluster_size) {
/* could not compress: write normal cluster */
ret = qcow2_co_pwritev(bs, offset, bytes, qiov, 0);
if (ret < 0) {
--
1.9.1
