On Thu, Jul 13, 2017 at 02:11:09PM +0200, Halil Pasic wrote: > > > On 07/12/2017 09:20 PM, Eduardo Habkost wrote: > > On Wed, Jul 12, 2017 at 07:49:22PM +0200, Halil Pasic wrote: > >> On 07/11/2017 02:43 AM, Eduardo Habkost wrote: > >>> This reverts commit 0bcba41fe379e4c6834adcf1456d9099db31a5b2. > >>> > >>> The bug addressed by that commit is now fixed in a better way by the > >>> commit "qdev: fix the order compat and global properties are applied". > >>> > >>> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > >> > >> Reviewed-by: Halil Pasic <pa...@linux.vnet.ibm.com> > >> > >> Note: It is not like the effect of commit 0bcba41fe3 is canceled > >> out with your first patch in place. It depends on the client > >> code (the implementation of the individual devices) wether > >> this patch changes something or not. I did not check myself. > >> So the did you verify that nothing breaks with this change applies > >> here too. > > > > I don't get this part. I don't see how individual devices > > implementation will be able to affect the outcome after this > > patch is applied. > > > > GlobalProperty::driver is not used as input for > > object_property_parse() at all (see qdev_prop_set_globals()). > > This means exactly the same property setter is invoked when > > registering "<superclass>.<property>" or "<subclass>.<property>". > > The only difference introduced by this series is in the ordering > > of the object_property_parse() calls. > > > > And even the object_property_parse() call ordering is not > > affected by this patch at all, because of patch 1/3. Patch 1/3 > > will ensure the properties will be applied in exactly the same > > order they were registered, so this patch should introduce > > absolutely no behavior change on any device. > > > > Resolving this disagreement IMHO depends on resolving our disagreement > about patch 1. Let us postpone this until we have an agreement > there.
Your observation on patch 1 was correct, so the ordering of object_property_parse() calls will change if using pseries <= 2.3 and "-global spapr-pci-vfio-host-bridge". -- Eduardo
