On Thu, 13 Jul 2017 13:02:35 +0200
Ladi Prosek <lpro...@redhat.com> wrote:
> virtqueue_error includes queue index in the error output and is preferred
> for errors that pertain to a virtqueue rather than to the device as a whole.
>
> Signed-off-by: Ladi Prosek <lpro...@redhat.com>
> ---
> hw/net/virtio-net.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index 5630a9e..b3d0b85 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -970,7 +970,7 @@ static void virtio_net_handle_ctrl(VirtIODevice *vdev,
> VirtQueue *vq)
> }
> if (iov_size(elem->in_sg, elem->in_num) < sizeof(status) ||
> iov_size(elem->out_sg, elem->out_num) < sizeof(ctrl)) {
> - virtio_error(vdev, "virtio-net ctrl missing headers");
> + virtqueue_error(vq, "virtio-net ctrl missing headers");
This does not add much information, as there's just one control queue
anyway, but it doesn't hurt either.
> virtqueue_detach_element(vq, elem, 0);
> g_free(elem);
> break;
Reviewed-by: Cornelia Huck <coh...@redhat.com>
