On 11 July 2017 at 21:58, Eduardo Habkost <ehabk...@redhat.com> wrote: > On Tue, Jul 11, 2017 at 09:49:30PM +0100, Peter Maydell wrote: >> It's basically GNU coding standard style vs Linux kernel style; >> there's a mix because some contributors are more used to working >> on the kernel, and some more used to working with gcc, glibc, >> etc, and we haven't made a firm "comments must be like this" >> statement (and of course historical practice in the codebase >> is all over the place). >> >> We also have both of the flavours the kernel style guide >> documents: >> https://www.kernel.org/doc/html/v4.10/process/coding-style.html#commenting >> (I usually use the style the kernel has for net/ personally.) >> >> So I don't think that "we" the project have a preferred >> format; but "we" individual contributors probably >> have individual preferences ;-) > > Thanks for the info. Please forget when I said I was going to > send a CODING_STYLE patch for that. :)
I was just giving the historical context, not necessarily arguing that we shouldn't try to impose a standard style now. (I have no strong opinion on that, beyond that style recommendations backed up by patches to checkpatch win over those without.) thanks -- PMM
