On 07/09/2017 11:14 AM, Emilio G. Cota wrote:
On Sun, Jul 09, 2017 at 10:45:55 -1000, Richard Henderson wrote:
On 07/08/2017 09:50 PM, Emilio G. Cota wrote:
+ /* includes aborted translations because of exceptions */
+ atomic_set(&prof->tb_count1, prof->tb_count1 + 1);
Again, atomic_set without atomic_read is pointless.
Either you're trying to give the compiler extra information, or you aren't.
See my comment to patch 3.
I still disagree. It's Just Plain Confusing.
You'll continue to get questions like this from me and other reviewers in
future. And it's not like avoiding atomic_read here makes anything faster.
Both forms will compile to the same assembler.
r~
