Emilio G Cota writes: > On Wed, Jun 28, 2017 at 15:40:52 +0300, Lluís Vilanova wrote: [,,,] >> @@ -8425,7 +8415,7 @@ void gen_intermediate_code(CPUState *cpu, >> TranslationBlock *tb) >> dc-> code64 = (flags >> HF_CS64_SHIFT) & 1; >> #endif >> dc-> flags = flags; >> - dc->jmp_opt = !(dc->tf || cpu->singlestep_enabled || >> + dc->jmp_opt = !(dc->tf || dc->base.singlestep_enabled ||
> Why this change and not leaving cpu->singlestep_enabled? The single-stepping info is initialized by the generic code into dc->base, and so I wanted to keep a bit more code consistency by unifying its use (on places I touched). In fact, using dc->base ensures translation will be consistent even if in the future cpu->singlestep_enabled is allowed to change. Cheers, Lluis
