* Daniel P. Berrange (berra...@redhat.com) wrote: > On Wed, Jul 05, 2017 at 03:43:02PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > > > > The QMP query-vnc interfaces have gained a lot more information that > > the HMP interfaces hasn't got yet. Update it. > > > > Note the output format has changed, but this is HMP so that's OK. > > > > In particular, this now includes client information for reverse > > connections: > > > > -vnc :0 > > (qemu) info vnc > > default: > > Server: 0.0.0.0:5900 (ipv4) > > Auth: none (Sub: none) > > Auth: none (Sub: none) > > If you're reporting Auth: against the individual Server entry, > there's no reason to report it at the top level too. We only > keep that duplication in QMP for sake of backcompat, which > is not important for HMP
Where would it get reported for a 'reverse' connection then? That has no server entry. Dave > > > > (Now connect a client) > > > > (qemu) info vnc > > default: > > Server: 0.0.0.0:5900 (ipv4) > > Auth: none (Sub: none) > > Client: 127.0.0.1:51828 (ipv4) > > x509_dname: none > > username: none > > Auth: none (Sub: none) > > > > -vnc localhost:7000,reverse > > (qemu) info vnc > > default: > > Client: ::1:7000 (ipv6) > > x509_dname: none > > username: none > > Auth: none (Sub: none) > > > > -vnc :1,password,id=rev -vnc localhost:7000,reverse > > (qemu) info vnc > > default: > > Client: ::1:7000 (ipv6) > > x509_dname: none > > username: none > > Auth: none (Sub: none) > > rev: > > Server: 0.0.0.0:5901 (ipv4) > > Auth: vnc (Sub: none) > > Client: 127.0.0.1:53616 (ipv4) > > x509_dname: none > > username: none > > Auth: vnc (Sub: none) > > > > This was originally RH bz 1461682 > > > > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
