On 06/29/2017 01:43 PM, Manos Pitsidianakis wrote: > Now that passing the call to bs->file is the default for some bdrv_* > callbacks, remove the duplicate implementations in block/raw-format.c > > Signed-off-by: Manos Pitsidianakis <el13...@mail.ntua.gr> > --- > block/raw-format.c | 32 +------------------------------- > 1 file changed, 1 insertion(+), 31 deletions(-) >
> @@ -479,16 +454,11 @@ BlockDriver bdrv_raw = {
> .bdrv_truncate = &raw_truncate,
> .bdrv_getlength = &raw_getlength,
> .has_variable_length = true,
> - .bdrv_get_info = &raw_get_info,
> .bdrv_refresh_limits = &raw_refresh_limits,
> .bdrv_probe_blocksizes = &raw_probe_blocksizes,
> .bdrv_probe_geometry = &raw_probe_geometry,
> - .bdrv_media_changed = &raw_media_changed,
> - .bdrv_eject = &raw_eject,
> - .bdrv_lock_medium = &raw_lock_medium,
> .bdrv_co_ioctl = &raw_co_ioctl,
> - .create_opts = &raw_create_opts,
> - .bdrv_has_zero_init = &raw_has_zero_init
> + .create_opts = &raw_create_opts
Please use a trailing comma here. It causes less churn in future patches
if you don't have to have a -/+ line pair just re-adding the comma.
(Yes, we didn't have a trailing comma, but we should have had one; your
patch is now the chance to make it so).
With that fixed, you can add:
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
