On Fri, Jun 30, 2017 at 03:57:23PM +0200, Max Reitz wrote: > On 2017-06-30 15:05, Eric Blake wrote: > > On 06/30/2017 07:33 AM, Max Reitz wrote: > > > >>> The assertion is caused by migrate_add_blocker() called before > >>> initialization of migration object. I'll fix it. > >> > >> Thanks!
Should be my thanks to you for reporting this. :) > >> > >>> But even with a fix (so I can pass 055 now), I still cannot pass some > >>> of the other tests. Errors I got: > >>> > >>> https://pastebin.com/ACqbXAYd > >>> > >>> I am not familiar with iotests. Is above usual? Looks like it still > >>> includes 3 failures, and some output mismatch. > >> > >> Well, not usual. But 068 just is broken on master currently (Stefan has > >> sent "virtio: use ioeventfd in TCG and qtest mode" to fix it, and it's > >> part of his latest pull request). The failure in test 087 is because you > >> don't have aio=native enabled in your build, as the message says. :-) > > > > We could obviously patch 087 to gracefully skip instead of fail when the > > build doesn't support running it. > > > >> > >> I'm not sure about 118. Maybe the os.chmod() doesn't work as intended on > >> your machine...? Because it tries to open a read-only image as > >> read/write and wants to see it fail (which it doesn't in your case). > > > > Maybe a run-as-root issue, where root can write to the file in spite of > > permissions? > > That's what I had in mind, too. > > > Ideally, I'm reluctant to run testsuites as root without > > good reason (or at least a good sandbox), for fear that a bug in the > > testsuite will hose my system. > > I never do. :-) Good reason. I'll definitely switch to non-root even on my dev machine next time, and also I think I'll also switch to use xfs for my rootfs (I won't let you know that I'm using btrfs :). > > There is one test which requires it, but well, that just never gets run > on my machine (and I don't feel very sorry about it). So looks like I didn't break the rest of the failed tests, good. Then I'll send the fix soon. Thanks! -- Peter Xu
