On 2017-06-28 16:21, Eric Blake wrote: > POSIX says that backslashes in the arguments to 'echo', as well as > any use of 'echo -n' and 'echo -e', are non-portable; it recommends > people should favor 'printf' instead. This is definitely true where > we do not control which shell is running (such as in makefile snippets > or in documentation examples). But even for scripts where we > require bash (and therefore, where echo does what we want by default), > it is still possible to use 'shopt -s xpg_echo' to change bash's > behavior of echo. And setting a good example never hurts when we are > not sure if a snippet will be copied from a bash-only script to a > general shell script (although I don't change the use of non-portable > \e for ESC when we know the running shell is bash). > > Replace 'echo -n "..."' with 'printf "..."', and 'echo -e "..."' > with 'printf "...\n"'. > > In the qemu-iotests check script, also fix unusual shell quoting > that would result in word-splitting if 'date' outputs a space. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > > Of course, Stefan's pending patch: > [PATCH 3/5] qemu-iotests: 068: extract _qemu() function > also touches 068, so there may be some (obvious) merge conflicts > to resolve there depending on what goes in first. > > qemu-options.hx | 4 ++-- > tests/multiboot/run_test.sh | 10 +++++----- > tests/qemu-iotests/051 | 7 ++++--- > tests/qemu-iotests/068 | 2 +- > tests/qemu-iotests/142 | 48 > ++++++++++++++++++++++----------------------- > tests/qemu-iotests/171 | 14 ++++++------- > tests/qemu-iotests/check | 18 ++++++++--------- > tests/rocker/all | 10 +++++----- > tests/tcg/cris/Makefile | 8 ++++---- > 9 files changed, 61 insertions(+), 60 deletions(-)
Question 1: Who's going to take this? :-) Question 2: This breaks 171 if TEST_DIR contains a % (e.g. "TEST_DIR=/tmp/foo%% ./check -raw 171"). Is that OK? Max
signature.asc
Description: OpenPGP digital signature
