* Pradeep Jagadeesh (pradeepkiruv...@gmail.com) wrote: > This patch creates a throttle initialization function to maximize the > code reusability. The same code is also used by fsdev. > > Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com>
Acked-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > --- > hmp.c | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) > > diff --git a/hmp.c b/hmp.c > index 8c72c58..220d301 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -1749,20 +1749,29 @@ void hmp_change(Monitor *mon, const QDict *qdict) > hmp_handle_error(mon, &err); > } > > +static void hmp_initialize_io_throttle(IOThrottle *iot, const QDict *qdict) > +{ > + iot->has_id = true; > + iot->id = (char *) qdict_get_str(qdict, "id"); > + iot->bps = qdict_get_int(qdict, "bps"); > + iot->bps_rd = qdict_get_int(qdict, "bps_rd"); > + iot->bps_wr = qdict_get_int(qdict, "bps_wr"); > + iot->iops = qdict_get_int(qdict, "iops"); > + iot->iops_rd = qdict_get_int(qdict, "iops_rd"); > + iot->iops_wr = qdict_get_int(qdict, "iops_wr"); > +} > + > void hmp_block_set_io_throttle(Monitor *mon, const QDict *qdict) > { > Error *err = NULL; > + IOThrottle *iothrottle; > BlockIOThrottle throttle = { > .has_device = true, > .device = (char *) qdict_get_str(qdict, "device"), > - .bps = qdict_get_int(qdict, "bps"), > - .bps_rd = qdict_get_int(qdict, "bps_rd"), > - .bps_wr = qdict_get_int(qdict, "bps_wr"), > - .iops = qdict_get_int(qdict, "iops"), > - .iops_rd = qdict_get_int(qdict, "iops_rd"), > - .iops_wr = qdict_get_int(qdict, "iops_wr"), > }; > > + iothrottle = qapi_BlockIOThrottle_base(&throttle); > + hmp_initialize_io_throttle(iothrottle, qdict); > qmp_block_set_io_throttle(&throttle, &err); > hmp_handle_error(mon, &err); > } > -- > 1.8.3.1 > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK