Emilio G Cota writes: > On Wed, Jun 28, 2017 at 14:21:29 +0300, Lluís Vilanova wrote: >> Emilio G Cota writes: >> > I wanted to save you some time and sent a v9 yesterday with these >> > same changes -- although I see some changes in my v8 didn't make it >> > to your v9. For this iteration I only added more perf numbers to the >> > last patch, see here: >> > https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg05764.html >> >> Woops, sorry about the duplicate effort. >> >> I just dropped the rename of variable trace_ds, since I prefer names whose >> purpose can be more easily understood.
> - I think trace_vcpu_dstate is way too long (IMO a short name + a comment > in the struct is better). > - You missed a change I made to patch 3: >> [cota: use CPU_TRACE_DSTATE_MAX_EVENTS instead of >> trace_get_vcpu_event_count()] > Was that intentional? No it wasn't. I'll look into it for the next series. > - Would be nice to include the perf numbers I got, along with yours. I'll add them to the cover and commit message. Thanks, Lluis
