On 14/06/2017 13:04, Fam Zheng wrote: > On Mon, 06/12 19:26, Peter Maydell wrote: >> On 8 June 2017 at 12:56, Fam Zheng <f...@redhat.com> wrote: >>> The following changes since commit 64175afc695c0672876fbbfc31b299c86d562cb4: >>> >>> arm_gicv3: Fix ICC_BPR1 reset value when EL3 not implemented (2017-06-07 >>> 17:21:44 +0100) >>> >>> are available in the git repository at: >>> >>> git://github.com/famz/qemu.git tags/docker-and-block-pull-request >>> >>> for you to fetch changes up to 383226d7f90e83fd2b4ea5fbedf67bd9d3173221: >>> >>> block: make accounting thread-safe (2017-06-08 19:09:23 +0800) >>> >>> ---------------------------------------------------------------- >>> >>> v3: Update Paolo's series to fix make check on OSX. >>> >>> ---------------------------------------------------------------- >> >> This still fails on OSX: >> >> GTESTER tests/test-blockjob >> qemu: qemu_mutex_lock: Invalid argument >> >> The backtrace is different from last time: >> >> * thread #1: tid = 0x7f066a, 0x00007fffc611ad42 >> libsystem_kernel.dylib`__pthread_kill + 10, queue = >> 'com.apple.main-thread', stop reason = signal SIGABRT >> * frame #0: 0x00007fffc611ad42 libsystem_kernel.dylib`__pthread_kill + 10 >> frame #1: 0x00007fffc6208457 libsystem_pthread.dylib`pthread_kill + 90 >> frame #2: 0x00007fffc6080420 libsystem_c.dylib`abort + 129 >> frame #3: 0x00000001000c1265 >> test-blockjob`error_exit(err=<unavailable>, msg=<unavailable>) + 53 at >> qemu-thread-posix.c:36 >> frame #4: 0x00000001000c1327 >> test-blockjob`qemu_mutex_lock(mutex=<unavailable>) + 151 at >> qemu-thread-posix.c:63 >> frame #5: 0x000000010005eef7 >> test-blockjob`bdrv_do_release_matching_dirty_bitmap [inlined] >> bdrv_dirty_bitmaps_lock(bs=0x0000000101806000) + 39 at >> dirty-bitmap.c:58 >> frame #6: 0x000000010005eee7 >> test-blockjob`bdrv_do_release_matching_dirty_bitmap(bs=0x0000000101806000, >> bitmap=0x0000000000000000, only_named=true) + 23 at dirty-bitmap.c:349 >> frame #7: 0x000000010000962d test-blockjob`bdrv_delete [inlined] >> bdrv_close(bs=0x0000000101806000) + 32 at block.c:3042 >> frame #8: 0x000000010000960d >> test-blockjob`bdrv_delete(bs=0x0000000101806000) + 61 at block.c:3229 >> frame #9: 0x0000000100043da2 >> test-blockjob`blk_remove_bs(blk=0x0000000100d0a7d0) + 98 at >> block-backend.c:607 >> frame #10: 0x0000000100001318 test-blockjob`test_job_ids [inlined] >> destroy_blk(blk=0x0000000100d0a7d0) + 29 at test-blockjob.c:83 >> frame #11: 0x00000001000012fb test-blockjob`test_job_ids + 411 at >> test-blockjob.c:140 >> frame #12: 0x000000010070d91d >> libglib-2.0.0.dylib`g_test_run_suite_internal + 626 >> frame #13: 0x000000010070dae1 >> libglib-2.0.0.dylib`g_test_run_suite_internal + 1078 >> frame #14: 0x000000010070d198 libglib-2.0.0.dylib`g_test_run_suite + 266 >> frame #15: 0x0000000100001148 >> test-blockjob`main(argc=<unavailable>, argv=<unavailable>) + 88 at >> test-blockjob.c:152 >> frame #16: 0x00007fffc5fec235 libdyld.dylib`start + 1 >> frame #17: 0x00007fffc5fec235 libdyld.dylib`start + 1 > > Paolo: missing "qemu_mutex_init(&bs->dirty_bitmap_mutex)" in bdrv_new()?
Yes. :( > (Any idea what is the easiest way to add a (VM|container|baremetal) OSX build > env to patchew?) Pretty hard, but we could add some code to detect uninitialized QemuMutex instead. Paolo
