Philippe Mathieu-Daudé <f4...@amsat.org> writes: > remove some copy/paste leftover, code seems sane. > > while running Alex Bennée's image aarch64-linux-3.15rc2-buildroot.img: > > Trace 0x7fa1904b0890 [0: ffffffc00036cd04] > ---------------- > IN: > 0xffffffc00036cd24: 5ac00694 rev16 w20, w20 > > OP: > ---- ffffffc00036cd24 0000000000000000 0000000000000000 > ext32u_i64 tmp3,x20 > ext16u_i64 tmp2,tmp3 > bswap16_i64 x20,tmp2 > movi_i64 tmp4,$0x10 > shr_i64 tmp2,tmp3,tmp4 > ext16u_i64 tmp2,tmp2 > bswap16_i64 tmp2,tmp2 > deposit_i64 x20,x20,tmp2,$0x10,$0x10 > > Linking TBs 0x7fa1904b0890 [ffffffc00036cd04] index 0 -> 0x7fa1904b0aa0 > [ffffffc00036cd24] > Trace 0x7fa1904b0aa0 [0: ffffffc00036cd24] > TODO qemu/tci.c:1049: tcg_qemu_tb_exec() > qemu/tci.c:1049: tcg fatal error > Aborted > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
Possibly the only person who has run tci recently ;-) Reviewed-by: Alex Bennée <alex.ben...@linaro.org> > --- > > there is no entry in MAINTAINERS for this file, I think it should it go under: > "Tiny Code Generator (TCG) / Common code" > > tci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tci.c b/tci.c > index 4bdc645f2a..f39bfb95c0 100644 > --- a/tci.c > +++ b/tci.c > @@ -1046,7 +1046,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t > *tb_ptr) > break; > #if TCG_TARGET_HAS_bswap16_i64 > case INDEX_op_bswap16_i64: > - TODO(); > t0 = *tb_ptr++; > t1 = tci_read_r16(&tb_ptr); > tci_write_reg64(t0, bswap16(t1)); -- Alex Bennée
