Noted, I have had a look at porting the xenfb input handlers to the qemu_input_handler_*() functions, and will post an update that combines patch
3 and 4 of this series. From: Gerd Hoffmann<mailto:kra...@redhat.com> Sent: 08 June 2017 14:39 To: Owen Smith<mailto:owen.sm...@citrix.com>; qemu-devel@nongnu.org<mailto:qemu-devel@nongnu.org> Cc: sstabell...@kernel.org<mailto:sstabell...@kernel.org>; Anthony Perard<mailto:anthony.per...@citrix.com>; xen-de...@lists.xenproject.org<mailto:xen-de...@lists.xenproject.org> Subject: Re: [PATCH 3/4] ui/input: Add activate/remove for keyboard handlers diff --git a/ui/input-legacy.c b/ui/input-legacy.c > index 7159747..fbe1ce7 100644 > --- a/ui/input-legacy.c > +++ b/ui/input-legacy.c > @@ -142,6 +142,18 @@ QEMUPutKbdEntry > *qemu_add_kbd_event_handler(QEMUPutKBDEvent *func, void *opaque) > return entry; > } > > +void qemu_activate_kbd_event_handler(QEMUPutKbdEntry *entry) Please don't add new code to input-legacy.c please. Switch your code to use the new qemu_input_handler_*() functions directly instead. cheers, Gerd
