On Thu, Jun 08, 2017 at 03:42:32PM +0200, Greg Kurz wrote: > I've provided answers for all comments from the v3 review that I deliberately > don't address in v4.
I've merged patches 1-4. 5 & 6 I'm still reviewing.
>
> v4: - some patches from v3 got merged
> - added some more preparatory cleanup in xics (patches 1,2)
> - merge cpu_setup() handler into realize() (patch 4)
> - see individual changelog for patches 3 and 6
>
> v3: - preparatory cleanup in pnv (patch 1)
> - rework ICPState realization and vmstate registration (patches 2,3,4)
> - fix migration using dummy icp/server entries (patch 5)
>
> v2: - some patches from v1 are already merged in ppc-for-2.10
> - added a new fix to a potential memory leak (patch 1)
> - consolidate dt_id computation (patch 3)
> - see individual changelogs for patch 2 and 4
>
> I could successfully do the following on POWER8 host with full cores (SMT8):
>
> 1) start a pseries-2.9 machine with QEMU 2.9:
> -smp cores=1,threads=2,maxcpus=8
> 2) hotplug a core:
> device_add host-spapr-cpu-core,core-id=4
> 3) migrate to QEMU 2.10 configured with core-id 0,4
> 4) hotplug another core:
> device_add host-spapr-cpu-core,core-id=2
> 5) migrate back to QEMU 2.9 configured with core-id 0,4,2
> 6) hotplug the core in the last available slot:
> device_add host-spapr-cpu-core,core-id=6
> 7) migrate to QEMU 2.10 configured with core-id 0,4,2,6
>
> I could check that the guest is functional after each migration.
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
