On 05/06/2017 14:24, Eric Blake wrote: > On 06/05/2017 03:52 AM, Stefan Fritsch wrote: >> Sending a break on a serial console can be useful for debugging the >> guest. But not all chardev backends support sending breaks (only telnet >> and mux do). The chardev-send-break command allows to send a break even >> if using other backends. >> >> Signed-off-by: Stefan Fritsch <s...@sfritsch.de> >> --- >> chardev/char.c | 12 ++++++++++++ >> hmp-commands.hx | 16 ++++++++++++++++ >> hmp.c | 8 ++++++++ >> hmp.h | 1 + >> qapi-schema.json | 20 ++++++++++++++++++++ >> 5 files changed, 57 insertions(+) > > Is there an obvious test that we can enhance to add coverage of the new > QMP command?
You could have a new test covering hw/char/serial.c, but I wouldn't let that hold the patch. Paolo
signature.asc
Description: OpenPGP digital signature
