On Mon, Jun 05, 2017 at 09:24:38AM +0200, Andrew Jones wrote: > On Fri, Jun 02, 2017 at 09:46:35AM +0000, Marc-André Lureau wrote: > > Hi > > > > On Thu, Jun 1, 2017 at 10:19 PM Eric Blake <ebl...@redhat.com> wrote: > > > > > On 06/01/2017 01:06 PM, Laszlo Ersek wrote: > > > > On 06/01/17 15:03, Marc-André Lureau wrote: > > > >> One way or another, the guest could communicate various dump info (via > > > >> guest agent or vmcoreinfo device) and populate that structure. It can > > > >> then be used to augment the dump with various details, as done in the > > > >> following patch. > > > >> > > > >> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > > >> --- > > > >> include/sysemu/dump-info.h | 18 ++++++++++++++++++ > > > >> dump.c | 3 +++ > > > >> 2 files changed, 21 insertions(+) > > > >> create mode 100644 include/sysemu/dump-info.h > > > >> > > > >> diff --git a/include/sysemu/dump-info.h b/include/sysemu/dump-info.h > > > >> new file mode 100644 > > > >> index 0000000000..d2378e15e2 > > > >> --- /dev/null > > > >> +++ b/include/sysemu/dump-info.h > > > >> @@ -0,0 +1,18 @@ > > > >> +#ifndef DUMP_INFO_H > > > >> +#define DUMP_INFO_H > > > > > > >> > > > > > > > > Can you please spell out, in the commit message, the reason for > > > > introducing a new header file? (I suspect your reason, but it should be > > > > documented explicitly.) > > > > > > Also, should you have a copyright header in the new file? And does > > > MAINTAINERS cover it? > > > > > > > None of the dump support is covered. Based on commit history, I can suggest > > Wen Congyang, as original author. > > Sadly, Qiao Nuohan cannot be reached with his mail today (anyone knows if > > he is still contributing?). Laszlo has done significant changes and reviews > > too. I can also propose myself to help with reviews. > > > > Wen or Laszla, do you want to be the main maintainer? > > What about Peter Xu (CC'ed)? He'll have to state whether he has time and > interest, but I see he's contributed quite a bit to dump.c.
I believe those were the first commits of mine when working on detached dump, after that I didn't really work on it anymore. So I guess I may not be the best candidate. Also, I admit my bandwidth is limited as well recently. Thanks Drew for mentioning me anyway. :-) -- Peter Xu
