Hi On Mon, Jun 5, 2017 at 2:15 PM Peter Maydell <peter.mayd...@linaro.org> wrote:
> On 2 June 2017 at 20:15, Marc-André Lureau <marcandre.lur...@gmail.com> > wrote: > > Sorry, git-publish printed an error on invalid remote, but keep going. I > > should fix it. Here is the new pull request: > > > > The following changes since commit > 43771d5d92312504305c19abe29ec5bfabd55f01: > > > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-05-31' > > into staging (2017-06-01 16:39:16 +0100) > > > > are available in the git repository at: > > > > https://github.com/elmarco/qemu.git tags/chrfe-pull-request > > > > > > for you to fetch changes up to 6b10e573d15ef82dbc5c5b3726028e6642e134f6: > > > > char: move char devices to chardev/ (2017-06-02 11:33:53 +0400) > > Thanks, applied to master. > > You forgot to add your signed-off-by line as submaintainer to the > commit from Philippe -- since it's a two line patch I didn't think it > Oh I didn't know I have to add my sign-off too, I thought reviewed-by was enough. Ok > was worth pushing back for a respin, but it's worth adding an > automated "check all commits have my signoff" to your "make a pull > request" script I think. > > For example, see lines 98--109 in my script: > > https://git.linaro.org/people/peter.maydell/misc-scripts.git/tree/make-pullreq Ok, I am using git-publish (btw, Stefan merged a fix to avoid the previous pullreq issue), and it seems -s will add missing sign-off during format-patch. Thanks, > > > thanks > -- PMM > -- Marc-André Lureau
