On Tue, May 30, 2017 at 2:04 PM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 21 May 2017 at 16:29, Krzysztof Kozlowski <k...@kernel.org> wrote: >> This is a collection of three already sent patchsets [1] [2] [3]. >> >> >> Changes since previous versions (v2): >> 1. Patch 11/11: set BIT(8) in PS_HOLD to fix power off on Linux v4.12-rc1. >> 2. Add reviewed-by tags. >> >> >> The first patch in set is a bugfix which also exposes problem of cpuidle. >> Kernel compiled with disabled CPU_IDLE works fine (two CPUs, coming SGIs, >> poweroff working) but with CPU_IDLE it behaves bad due to low-power >> mode (AFTR). This was discussed at [1]. > > So is this a regression compared to our current model? I was > under the impression from the previous thread that it was, > which is why I didn't apply that patchset.
It depends how wide understanding of regression you have. :) 1. Before this patch, second CPU could not boot. System was usable but worked on only one CPU. 2. Before this patch, kernel's IRQ work is broken. None of IRQ work are executed which is mostly visible during poweroff - system hangs on syncing IRQ works. 3. With this patch, second CPU boots and IRQ works properly (so poweroff is possible). 4. However with this patch, Linux kernel with cpuidle enabled (which is also included in many kernel defconfigs), the system is very unresponsive. So overall... a lot of things were broken already. This patches fixes them... but breaks different thing. Best regards, Krzysztof
