On 05/26/2017 06:58 AM, Mao Zhongyi wrote: In the subject: s/porpagate/propagate/
> ioh3420_interrupts_init() and its callers rp_realize() fill error > message to local_err, then propagate it to errp by error_porpagate(), and again > which's not necessary. So eliminate it and pass errp directly instead s/which's/which is/ (English does not have the abbreviation which's) > of local_err. Of course, error_propagate() also has been removed. > > Signed-off-by: Mao Zhongyi <maozy.f...@cn.fujitsu.com> > --- > v2: > * Drop the part of wrong handling that ignored the fact that if > pci_qdev_realize()'s caller pass errp = NULL. > The code portion is fine, so with the commit message fixed (which a maintainer might do without needing you to send a v3), Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
