On 05/25/2017 10:26 AM, Vladimir Sementsov-Ogievskiy wrote: > The function should return actually used by top-level format driver
s/actually/the allocation actually/ > space (in it's .file). It differs from bdrv_get_allocated_file_size, s/it's/its/ (remember, "it's" is only appropriate if "it is" can be used in its place) > which returns allocated on fs file size. s/allocated on fs file size/the disk usage of the underlying file/ So this is a measure of how many clusters a qcow2 image is currently using (including metadata clusters, and regardless of whether those clusters happen to point to a hole in the underlying protocol layer)? > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > block.c | 15 +++++++++++++++ > include/block/block.h | 1 + > include/block/block_int.h | 1 + > 3 files changed, 17 insertions(+) > > diff --git a/block.c b/block.c > index ba22fc0dfb..6e1a435490 100644 > --- a/block.c > +++ b/block.c > @@ -3407,6 +3407,21 @@ int64_t bdrv_get_allocated_file_size(BlockDriverState > *bs) > } > > /** > + * Actually used by top-level format driver space (in it's .file) in bytes s/it's/its/ I think we can do better. How about: Return the amount of space allocated by the format driver (including metadata) in bytes, even if some of that space currently maps to holes in the underlying protocol file. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
