On Fri, May 19, 2017 at 11:27:49AM -0300, Daniel Henrique Barboza wrote: > Currenty we do not have any RTAS event that is reported by the > event-scan interface. The existing events, RTAS_LOG_TYPE_EPOW and > RTAS_LOG_TYPE_HOTPLUG, are being reported by the check-exception > interface and, as such, marked as 'exception=true'. > > Commit 79853e18d9, 'spapr_events: event-scan RTAS interface', added > the event_scan interface because the guest kernel requires it to > initialize other required interfaces. It is acting since then as > a stub because no events that would be reported by it were added > since then. However, the existence of the 'exception' boolean adds > an unnecessary load in the future migration of the pending_events, > sPAPREventLogEntry QTAILQ that hosts the pending RTAS events. > > To make the code cleaner and ease the future migration changes, this > patch makes the following changes: > > - remove the 'exception' boolean that filter these events. There is > nothing to filter since all events are reported by check-exception; > > - functions rtas_event_log_queue, rtas_event_log_dequeue and > rtas_event_log_contains don't receive the 'exception' boolean > as parameter; > > - event_scan function was simplified. It was calling > 'rtas_event_log_dequeue(mask, false)' that was always returning > 'NULL' because we have no events that are created with > exception=false, thus in the end it would execute a jump to > 'out_no_events' all the time. The function now assumes that > this will always be the case and all the remaining logic were > deleted. > > In the future, when or if we add new RTAS events that should > be reported with the event_scan interface, we can refer to > the changes made in this patch to add the event_scan logic > back. > > Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com>
Applied to ppc-for-2.10.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
