On 19/05/2017 17:51, Stefan Hajnoczi wrote: >> This series seems to have some coding style problems. See output below for >> more information: > Yikes, on second thought I've dropped the pull request for now. > > Please look at these coding style violations.
These are just a sample program, so I didn't really care much. But these three aren't: Checking PATCH 17/20: vhost-user-scsi: Introduce vhost-user-scsi host device... ERROR: do not use C99 // comments #216: FILE: hw/scsi/vhost-user-scsi.c:145: + // Turn on predefined features supported by this device ERROR: do not use C99 // comments #261: FILE: hw/scsi/vhost-user-scsi.c:190: + // Add the bootindex property for this object ERROR: do not use C99 // comments #265: FILE: hw/scsi/vhost-user-scsi.c:194: + // Set boot index according the the device config total: 3 errors, 0 warnings, 382 lines checked so I guess I'll fix the sample program too. Paolo
signature.asc
Description: OpenPGP digital signature
