> On 16/05/2017 22:22, Xu, Anthony wrote: > >> On 16/05/2017 03:21, Anthony Xu wrote: > >>> when smm is disabled, smram is not used, so disable it > >>> > >>> Signed-off-by: Anthony Xu <anthony...@intel.com> > >> > >> What is the benefit? > > > > This patch removes 1 memory region for i440 platform and 3 memory > regions > > for q35 platform. That makes functions which iterates memory region tree > > a little bit fast even the memory regions are disabled. > > Does it translate to anything measurable in benchmarks? Yes , we see boot time improvement with this patch in our setup (skip guest BIOS, disable guest PAM).
>Could you leave > the regions there, but skip the creation of the SMRAM address space in > register_smram_listener when the machine doesn't have SMM enabled? Sounds like you have concerns on removing smram regions. What are your concerns? -Anthony
