On 05/15/2017 07:11 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > scripts/coccinelle/return_directly.cocci | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Did you intend for this to be threaded with your other 'oslib: strip trailing '\n'...' patch? If so, where's the 0/2 cover letter and proper subject lines? At any rate, Reviewed-by: Eric Blake <ebl...@redhat.com> > > diff --git a/scripts/coccinelle/return_directly.cocci > b/scripts/coccinelle/return_directly.cocci > index 48680f2c2a..4cf50e75ea 100644 > --- a/scripts/coccinelle/return_directly.cocci > +++ b/scripts/coccinelle/return_directly.cocci > @@ -1,4 +1,4 @@ > -// replace 'R = X; return R;' with 'return R;' > +// replace 'R = X; return R;' with 'return X;' > @@ > identifier VAR; > expression E; > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
