On 2017年05月06日 03:36, no-re...@patchew.org wrote:
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH] Revert "Change net/socket.c to use socket_*()
functions" again
Message-id: 20170505162305.15763-1-berra...@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -;
then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20170504173745.27414-1-ebl...@redhat.com ->
patchew/20170504173745.27414-1-ebl...@redhat.com
Switched to a new branch 'test'
89f6b9d Revert "Change net/socket.c to use socket_*() functions" again
=== OUTPUT BEGIN ===
Checking PATCH 1/1: Revert "Change net/socket.c to use socket_*() functions"
again...
ERROR: braces {} are necessary for all arms of this statement
#56: FILE: net/socket.c:495:
+ if (parse_host_port(&saddr, host_str) < 0)
[...]
ERROR: braces {} are necessary for all arms of this statement
#159: FILE: net/socket.c:540:
+ if (parse_host_port(&saddr, host_str) < 0)
[...]
ERROR: space required before the open parenthesis '('
#172: FILE: net/socket.c:551:
+ for(;;) {
ERROR: braces {} are necessary for all arms of this statement
#192: FILE: net/socket.c:571:
+ if (!s)
[...]
total: 4 errors, 0 warnings, 162 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
Acked-by: Jason Wang <jasow...@redhat.com>
