Hi, I stumbled upon this code while working on arch_init.c cleanups:
On Thu, Dec 29, 2016 at 11:12:16PM +0100, Hervé Poussineau wrote: [...] > +static void ibm_40p_init(MachineState *machine) > +{ [...] > + /* initialize audio subsystem */ > + audio_init(); Why exactly did you need this, if main() already calls audio_init()? [...] > +static void ibm_40p_machine_init(MachineClass *mc) > +{ > + mc->desc = "IBM RS/6000 7020 (40p)", > + mc->init = ibm_40p_init; > + mc->max_cpus = 1; > + mc->pci_allow_0_address = true; > + mc->default_ram_size = 128 * M_BYTE; > + mc->block_default_type = IF_SCSI; > + mc->default_display = "std"; /* FIXME: should be S3 Trio */ > + mc->default_boot_order = "c"; > +} > + > +DEFINE_MACHINE("40p", ibm_40p_machine_init) > DEFINE_MACHINE("prep", prep_machine_init) > -- > 2.1.4 > > -- Eduardo