On 2017-05-02 09:16, Philippe Mathieu-Daudé wrote: > Hi Aurelien, > > On 05/01/2017 07:10 PM, Aurelien Jarno wrote: > > There is a confusion (and not only in the SH4 target) between tb->flags, > > env->flags and ctx->flags. To avoid it, split ctx->flags into > > ctx->tbflags and ctx->envflags. ctx->tbflags stays unchanged during the > > whole TB translation, while ctx->envflags evolves and is kept in sync > > with env->flags using TCG instructions. ctx->envflags now only contains > > the part that of env->flags that is contained in the TB state, i.e. the > > DELAY_SLOT* flags. > > I agree with your split, but I'd rather put the 2nd part of your commit > description as comments in the struct DisasContext declaration, if you mind > :)
Thanks for the review. I'll do that in the v2, although at some point it should probably go to some higher level documentation, as it is often a source of confusion. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurel...@aurel32.net http://www.aurel32.net
