On 04/28/2017 02:28 PM, Max Reitz wrote: > On 27.04.2017 03:46, Eric Blake wrote: >> No tests were covering write zeroes with unmap. Additionally, >> I needed to prove that my previous patches for correct status >> reporting and write zeroes optimizations actually had an impact. >> >> The test works for cluster_size between 8k and 2M (for smaller >> sizes, it fails because our allocation patterns are not contiguous >> with small clusters). >> >> Signed-off-by: Eric Blake <ebl...@redhat.com> >> >> --- >> v10: drop any changes to v2 files, rewrite test to work with updates >> earlier in the series, add a blkdebug probe >> v9: new patch >> --- >> tests/qemu-iotests/179 | 123 >> +++++++++++++++++++++++++++++++++++++++++++++ >> tests/qemu-iotests/179.out | 90 +++++++++++++++++++++++++++++++++ >> tests/qemu-iotests/group | 1 + >> 3 files changed, 214 insertions(+) >> create mode 100755 tests/qemu-iotests/179 >> create mode 100644 tests/qemu-iotests/179.out > > Can I convince you to write this test in a different way? I really have > a hard time following all of the writes and building a mental image of > how the qcow2 file should look in the end so I can compare it to the map > output. > > I'd like it better if you would check the qcow2 file after each group of > write operations, maybe even creating a new image for every such group. > But even just having more qemu-img map calls (and changing nothing else) > would help me a lot.
Will do. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
