On Thu, Apr 27, 2017 at 04:46:26PM +0200, Igor Mammedov wrote: > On Thu, 27 Apr 2017 16:05:42 +0200 > Markus Armbruster <arm...@redhat.com> wrote: > > Igor Mammedov <imamm...@redhat.com> writes: > > > On Thu, 27 Apr 2017 07:54:31 -0500 > > > Eric Blake <ebl...@redhat.com> wrote: [...] > > >> > > >> Markus has asked that all new QMP commands have some testsuite exposure; > > >> he may have some advice on what test would be best to modify to give us > > >> some coverage of this feature. > > > > I can't see the QMP command here, but... > > > > > Since it's basically validation of SLIT table, the test case > > > should be added to tests/bios-tables-test.c > > > > ... I figure there's new stuff to test all the same. > it could be a patch on top and doesn't have to hold this one if > author promises to write testcase
Agreed. I'm applying this to my machine-next branch, but I would like to get test cases before including it in a pull request. -- Eduardo
