This prevents qemu from hanging waiting for a client to connect. I have reproduced this when doing a loadvm but it may be a more general problem in that poll/accept may race if a client aborts the connection with a RST before the accept has completed. In either case the fix seems harmless.
Signed-off-by: Gianni Tedesco <gianni.tede...@citrix.com> diff --git a/ui/vnc.c b/ui/vnc.c index 864342e..172b988 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2736,5 +2736,6 @@ int vnc_display_open(DisplayState *ds, const char *display) vs->display = dpy; } } + socket_set_nonblock(vs->lsock); return qemu_set_fd_handler2(vs->lsock, NULL, vnc_listen_read, NULL, vs); }