On 04/25/2017 09:53 AM, Emilio G. Cota wrote:
The inline improves performance, as shown in upcoming commits' logs.
This commit is kept separate to ease review, since the inclusion
of tb-hash.h might be controversial. The problem here, which was
introduced before this commit, is that tb_hash_func() depends on
page_addr_t: this defeats the original purpose of tb-hash.h,
which was to be self-contained and CPU-agnostic.
Signed-off-by: Emilio G. Cota<c...@braap.org>
---
cpu-exec.c | 19 -------------------
include/exec/exec-all.h | 24 +++++++++++++++++++++++-
2 files changed, 23 insertions(+), 20 deletions(-)
Is there a reason we should just inline this code directly into
HELPER(lookup_tb_ptr)? I think that would save a bit of churn, and I can't
think of any other reason we'd want to use this function.
r~
